question - if you make a PR, do you sometimes just fix the minor error yourself and push it and then approve it? for example: like - devRant

Ranter

Comments

3

Lensflare

20221

3d

Yes
3

ScriptCoded

18871

3d

Don't quite follow but I can't approve my own prs
3

Lensflare

20221

3d

@ScriptCoded you can, if you change the policy :)
2

donkulator

3861

3d

If I've triple checked that it really is a minor change and I haven't accidentally made it into a major change, and I have a reasonable amount of confidence in the test coverage, then yes.
2

ScriptCoded

18871

3d

@Lensflare Well, ain't no way anyone's changing the policy where I work 😅
2

ScriptCoded

18871

3d

Okay that's kind of a lie actually. I think I could have that changed pretty easily if the team was on board 😅
2

Lensflare

20221

3d

@ScriptCoded imo it‘s better to be able to have this permission to change it and just not to do it because of common sense than not having this permission and later being stuck when you are the single person working on that project.
2

TerriToniAX

2617

3d

Cosmetic bugs such as typos are not even worth making a PR about. I just fix them on the fly.
1

BordedDev

1519

2d

@TerriToniAX "OH MY GOD WHY DID YOU PUSH TO main/master" messages incoming
1

TerriToniAX

2617

1d

@BordedDev

My colleagues are *not* jerks :)
1

BordedDev

1519

1d

@TerriToniAX Lucky bastard ;P (colleagues wouldn't care, but PM blows a gasket)

Related Rants

devRant © 2021 Hexical Labs LLC
Privacy Policy | Terms of Service